Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(nx): migrate nx to latest version #460

Merged
merged 3 commits into from
Jan 24, 2023
Merged

chore(nx): migrate nx to latest version #460

merged 3 commits into from
Jan 24, 2023

Conversation

bdebon
Copy link
Contributor

@bdebon bdebon commented Jan 24, 2023

What does this PR do?

> Link to the JIRA ticket

After some back and forth with nx team, the problem is now solved and the migration went smoothly.
nrwl/nx#14389

PR Checklist

Global

  • This PR does not introduce any breaking change
  • This PR introduces breaking change(s) and has been labeled as such
  • I have found someone to review this PR and pinged him

Store

  • This PR introduces new store changes

NX

  • I have run the dep-graph locally and made sure the tree was clean i.e no circular dependencies
  • I have followed the library pattern i.e feature, ui, data, utils

Clean Code

  • I made sure the code is type safe (no any)
  • I have included a feature flag on my feature, if applicable

@RemiBonnet
Copy link
Member

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] staging - chore(nx): migrate nx to latest version - 2023-01-24T11:10:38Z

Another comment will be posted when deployments are terminated

@nx-cloud
Copy link

nx-cloud bot commented Jan 24, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 235b480. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@bdebon bdebon requested a review from RemiBonnet January 24, 2023 11:10
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023 •
edited
Loading

Codecov Report

Merging #460 (d2de475) into staging (72cb4eb) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           staging     #460      +/-   ##
===========================================
+ Coverage    54.02%   54.04%   +0.01%     
===========================================
  Files          330      330              
  Lines         6689     6689              
  Branches      1503     1503              
===========================================
+ Hits          3614     3615       +1     
  Misses        2573     2573              
+ Partials       502      501       -1
Impacted Files Coverage Δ
.../clusters/src/lib/ui/card-cluster/card-cluster.tsx 100.00% <0.00%> (+10.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RemiBonnet
Copy link
Member

Your preview environment failed to be deployed !
Click on the link below to check the deployment logs.
👉 [PR] staging - chore(nx): migrate nx to latest version - 2023-01-24T11:10:38Z

@bdebon bdebon merged commit 5fc664f into staging Jan 24, 2023
@bdebon bdebon deleted the chore/migrate-nx-15.6.0 branch January 24, 2023 13:24
bdebon added a commit that referenced this pull request Jan 24, 2023
@bdebon
Revert "chore(nx): migrate nx to 15.6.0 (#460)"
7e0734e 
This reverts commit 5fc664f.
@bdebon bdebon mentioned this pull request Jan 24, 2023
Merged
@bdebon
Copy link
Contributor Author

bdebon commented Jan 26, 2023

🎉 This PR is included in version 1.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RemiBonnet RemiBonnet Awaiting requested review from RemiBonnet

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdebon @RemiBonnet @codecov-commenter